ROUND 1 della replica soccorso istruttorio speculare al BE Gepafin
bflows-bandi-be. Pacchetto base pronto, mancano scheduler/upload/email/FE
che vengono in round successivi.
==ARCHITETTURA DECISA CON CARLO==
- multi-tenancy lato BE: microservizio resta tenant-agnostic
- BE (bflows-bandi-be) fa polling sul nostro /internal e invia PEC/protocollo
tenant-aware (hub=1 Gepafin PEC_SERVICE, hub=2 SviluppUmbria MAILGUN_SERVICE)
- microservizio NON fa PEC ne protocollo, NON conosce hub_id
- endpoint interni autenticati via shared secret X-Internal-Secret
==MIGRATION DB (2)==
mig 7: ALTER TABLE remission_amendment_request ADD
response_days, extended_days, extension_date, internal_note,
amendment_document_path/type, amendment_initial_document_path,
response_document_path/type, protocol_id, email_log_id, user_action_id,
pec_sent_at, pec_failed_reason, pec_retry_after
+ 2 index partial (status pec-pending, deadline scadenti)
mig 8: nuova tabella remission_expiration_config (type, interval_days,
is_deleted) per reminder data-driven speculare a expiration_config BE.
Seeded con (AMENDMENT, 7) e (AMENDMENT, 2).
==MODELLI==
- RemissionAmendmentRequest esteso con 13 colonne nuove
- RemissionExpirationConfig nuovo
==SCHEMAS==
- AmendmentStatus enum (DRAFT, AWAITING, RESPONSE_RECEIVED, EXPIRED, CLOSED)
- AmendmentRequestCreate esteso (response_days, internal_note)
- AmendmentRequestUpdate nuovo (solo DRAFT)
- AmendmentExtend nuovo (proroga)
- AmendmentPendingPecOut, AmendmentPecDetail (per BE polling)
- MarkPecSent, MarkPecFailed (callback BE)
==ENDPOINT ISTRUTTORE (estesi o nuovi)==
- POST /{pid}/amendment crea DRAFT (modifica: non piu AWAITING diretto)
- PUT /{pid}/amendment/{id} modifica solo DRAFT [NUOVO]
- DELETE /{pid}/amendment/{id} elimina solo DRAFT [NUOVO]
- POST /{pid}/amendment/{id}/send DRAFT -> AWAITING [NUOVO]
- POST /{pid}/amendment/{id}/extend proroga deadline [NUOVO]
- POST /{pid}/amendment/{id}/reminder reminder manuale (flag pec_retry_after) [NUOVO]
- POST /{pid}/amendment/{id}/close chiude (AmendmentStatus enum al posto di stringhe)
- POST /{pid}/amendment/{id}/respond-beneficiary benef risponde
==ENDPOINT INTERNI /internal/remission-amendments (nuovi)==
- GET ?status=pending-pec|pending-reminder&since=
- GET /{id} detail per composizione PEC
- POST /{id}/mark-pec-sent callback BE success
- POST /{id}/mark-pec-failed callback BE failure
Auth: X-Internal-Secret header, 401 altrimenti.
==CONFIG==
RENDIC_INTERNAL_SECRET env var (default sandbox hard-coded).
==TEST E2E==
/tmp/test_amendment_v3.py - 10 step tutti verdi:
A reset T2 UNDER_REVIEW
B create DRAFT (response_days=15 default)
C update DRAFT (response_days=20, internal_note)
D send DRAFT->AWAITING, pratica AWAITING_AMENDMENT
E BE poll pending-pec vede amendment
F BE detail+mark-pec-sent salva protocol_id/email_log_id/user_action_id
G dopo mark-pec-sent scompare da pending-pec
H benef respond -> RESPONSE_RECEIVED
I istruttore close -> CLOSED, pratica torna UNDER_REVIEW
AUTH internal senza secret -> 401
==NEXT (non in questo commit)==
- scheduler APScheduler cron 01:00 EXPIRED + cron 09:00 reminder
- upload amendment_document (istruttore) + response_document (benef) via files router
- template email locali non-PEC (reminder istruttore, notifica chiusura)
- UI istruttore: lista amendment + form crea/invia + proroga + reminder manuale
- UI benef: vista amendment + risposta con upload
175 lines
8.2 KiB
Python
175 lines
8.2 KiB
Python
"""
|
|
Migration idempotente per sandbox.
|
|
Base.metadata.create_all() crea solo tabelle mancanti, non colonne aggiuntive.
|
|
Qui gestiamo ALTER TABLE ADD COLUMN IF NOT EXISTS per l'evoluzione dello schema.
|
|
|
|
Ogni migration è una stringa SQL che puo essere eseguita piu volte senza errori.
|
|
"""
|
|
from sqlalchemy import text
|
|
import logging
|
|
|
|
log = logging.getLogger("rendicontazione-api.migrations")
|
|
|
|
|
|
MIGRATIONS = [
|
|
# 2026-04-18: colonne file upload su remission_invoice
|
|
"""
|
|
ALTER TABLE gepafin_rendic.remission_invoice
|
|
ADD COLUMN IF NOT EXISTS storage_path varchar(1024),
|
|
ADD COLUMN IF NOT EXISTS mime varchar(128),
|
|
ADD COLUMN IF NOT EXISTS size_bytes bigint,
|
|
ADD COLUMN IF NOT EXISTS sha256 varchar(64),
|
|
ADD COLUMN IF NOT EXISTS uploaded_by integer,
|
|
ADD COLUMN IF NOT EXISTS uploaded_at timestamptz;
|
|
""",
|
|
# 2026-04-18: colonne file upload su remission_ula_employee
|
|
"""
|
|
ALTER TABLE gepafin_rendic.remission_ula_employee
|
|
ADD COLUMN IF NOT EXISTS storage_path varchar(1024),
|
|
ADD COLUMN IF NOT EXISTS mime varchar(128),
|
|
ADD COLUMN IF NOT EXISTS size_bytes bigint,
|
|
ADD COLUMN IF NOT EXISTS sha256 varchar(64),
|
|
ADD COLUMN IF NOT EXISTS uploaded_by integer,
|
|
ADD COLUMN IF NOT EXISTS uploaded_at timestamptz;
|
|
""",
|
|
# 2026-04-18: colonne file upload su remission_document
|
|
"""
|
|
ALTER TABLE gepafin_rendic.remission_document
|
|
ADD COLUMN IF NOT EXISTS storage_path varchar(1024),
|
|
ADD COLUMN IF NOT EXISTS mime varchar(128),
|
|
ADD COLUMN IF NOT EXISTS size_bytes bigint,
|
|
ADD COLUMN IF NOT EXISTS sha256 varchar(64),
|
|
ADD COLUMN IF NOT EXISTS uploaded_by integer;
|
|
""",
|
|
# 2026-04-18 v2: multi-tranche su remission_practice
|
|
# DROP UNIQUE su application_id (permette piu tranche per stessa domanda)
|
|
# aggiunge sequence_number, period_label, suggested_instructor_id
|
|
# nuova UNIQUE (application_id, sequence_number)
|
|
# partial index su assigned_instructor_id IS NULL per coda "da assegnare"
|
|
"""
|
|
ALTER TABLE gepafin_rendic.remission_practice
|
|
DROP CONSTRAINT IF EXISTS uq_remission_practice_application;
|
|
ALTER TABLE gepafin_rendic.remission_practice
|
|
ADD COLUMN IF NOT EXISTS sequence_number integer NOT NULL DEFAULT 1,
|
|
ADD COLUMN IF NOT EXISTS period_label varchar(100),
|
|
ADD COLUMN IF NOT EXISTS suggested_instructor_id integer;
|
|
DO $$
|
|
BEGIN
|
|
IF NOT EXISTS (
|
|
SELECT 1 FROM pg_constraint
|
|
WHERE conname = 'uq_remission_practice_app_seq'
|
|
AND conrelid = 'gepafin_rendic.remission_practice'::regclass
|
|
) THEN
|
|
ALTER TABLE gepafin_rendic.remission_practice
|
|
ADD CONSTRAINT uq_remission_practice_app_seq UNIQUE (application_id, sequence_number);
|
|
END IF;
|
|
END$$;
|
|
CREATE INDEX IF NOT EXISTS idx_remission_practice_unassigned
|
|
ON gepafin_rendic.remission_practice(assigned_instructor_id)
|
|
WHERE assigned_instructor_id IS NULL;
|
|
""",
|
|
# 2026-04-20: link documento a company_document del BE Gepafin (riutilizzo dal repository)
|
|
# Se source_company_document_id e valorizzato, il documento e selezionato dal repository
|
|
# company (gepafin_schema.company_document). Lo status/scadenza del sorgente governa
|
|
# semaforo UI e gate submit (documenti EXPIRED bloccano la trasmissione).
|
|
"""
|
|
ALTER TABLE gepafin_rendic.remission_document
|
|
ADD COLUMN IF NOT EXISTS source_company_document_id integer;
|
|
CREATE INDEX IF NOT EXISTS idx_remission_document_source
|
|
ON gepafin_rendic.remission_document(source_company_document_id)
|
|
WHERE source_company_document_id IS NOT NULL;
|
|
""",
|
|
# 2026-04-18 v2: tabella custom checks
|
|
# allineata allo storage adapter esistente (storage_path + mime + size + sha256)
|
|
# NON segue le specs RAG p1 che usavano document_filename (v1 obsoleta)
|
|
"""
|
|
CREATE TABLE IF NOT EXISTS gepafin_rendic.remission_custom_check_value (
|
|
id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
|
|
practice_id uuid NOT NULL REFERENCES gepafin_rendic.remission_practice(id) ON DELETE CASCADE,
|
|
check_code varchar(64) NOT NULL,
|
|
beneficiary_declared boolean NOT NULL DEFAULT false,
|
|
declared_at timestamptz,
|
|
storage_path varchar(1024),
|
|
mime varchar(128),
|
|
size_bytes bigint,
|
|
sha256 varchar(64),
|
|
document_uploaded_at timestamptz,
|
|
uploaded_by integer,
|
|
verification_status varchar(20) NOT NULL DEFAULT 'PENDING',
|
|
verification_notes text,
|
|
verified_by integer,
|
|
verified_at timestamptz,
|
|
created_at timestamptz NOT NULL DEFAULT NOW(),
|
|
updated_at timestamptz NOT NULL DEFAULT NOW(),
|
|
CONSTRAINT uq_custom_check_practice_code UNIQUE (practice_id, check_code)
|
|
);
|
|
CREATE INDEX IF NOT EXISTS idx_custom_check_practice
|
|
ON gepafin_rendic.remission_custom_check_value(practice_id);
|
|
""",
|
|
# 2026-04-20 v3: soccorso istruttorio speculare al BE Gepafin
|
|
# - stato DRAFT (istruttore prepara, non ancora inviato)
|
|
# - response_days + extended_days + extension_date (prolunghe)
|
|
# - internal_note (visibile solo istruttore, separata da request_text)
|
|
# - amendment_document_* (allegato istruttore al soccorso, firmato e no)
|
|
# - response_document_* (upload risposta beneficiario)
|
|
# - protocol_id + email_log_id + user_action_id (popolati dal BE via mark-pec-sent)
|
|
# - pec_sent_at + pec_failed_reason + pec_retry_after (tracking PEC asincrono)
|
|
# Lato microservizio NON gestiamo PEC ne protocollo: il BE multi-tenant
|
|
# (gepafin_schema.hub id=1 PEC_SERVICE, id=2 MAILGUN_SERVICE) fa polling
|
|
# su endpoint /internal/remission-amendments e notifica via mark-pec-sent/failed.
|
|
"""
|
|
ALTER TABLE gepafin_rendic.remission_amendment_request
|
|
ADD COLUMN IF NOT EXISTS response_days integer,
|
|
ADD COLUMN IF NOT EXISTS extended_days integer,
|
|
ADD COLUMN IF NOT EXISTS extension_date timestamptz,
|
|
ADD COLUMN IF NOT EXISTS internal_note text,
|
|
ADD COLUMN IF NOT EXISTS amendment_document_path varchar(1024),
|
|
ADD COLUMN IF NOT EXISTS amendment_document_type varchar(128),
|
|
ADD COLUMN IF NOT EXISTS amendment_initial_document_path varchar(1024),
|
|
ADD COLUMN IF NOT EXISTS response_document_path varchar(1024),
|
|
ADD COLUMN IF NOT EXISTS response_document_type varchar(128),
|
|
ADD COLUMN IF NOT EXISTS protocol_id varchar(128),
|
|
ADD COLUMN IF NOT EXISTS email_log_id integer,
|
|
ADD COLUMN IF NOT EXISTS user_action_id integer,
|
|
ADD COLUMN IF NOT EXISTS pec_sent_at timestamptz,
|
|
ADD COLUMN IF NOT EXISTS pec_failed_reason text,
|
|
ADD COLUMN IF NOT EXISTS pec_retry_after timestamptz;
|
|
CREATE INDEX IF NOT EXISTS idx_amendment_status_pec
|
|
ON gepafin_rendic.remission_amendment_request(status)
|
|
WHERE status IN ('DRAFT','AWAITING');
|
|
CREATE INDEX IF NOT EXISTS idx_amendment_deadline
|
|
ON gepafin_rendic.remission_amendment_request(deadline)
|
|
WHERE status = 'AWAITING';
|
|
""",
|
|
# 2026-04-20 v4: tabella config reminder data-driven, speculare al BE
|
|
# (expiration_config type='AMENDMENT' interval_days=N). Permette righe multiple
|
|
# per triggerare reminder a N gg diversi dalla scadenza (es. 7gg + 2gg).
|
|
"""
|
|
CREATE TABLE IF NOT EXISTS gepafin_rendic.remission_expiration_config (
|
|
id serial PRIMARY KEY,
|
|
type varchar(50) NOT NULL,
|
|
interval_days integer NOT NULL CHECK (interval_days > 0),
|
|
is_deleted boolean NOT NULL DEFAULT false,
|
|
created_at timestamptz NOT NULL DEFAULT NOW()
|
|
);
|
|
CREATE INDEX IF NOT EXISTS idx_expiration_config_type
|
|
ON gepafin_rendic.remission_expiration_config(type)
|
|
WHERE is_deleted = false;
|
|
INSERT INTO gepafin_rendic.remission_expiration_config (type, interval_days)
|
|
VALUES ('AMENDMENT', 7), ('AMENDMENT', 2)
|
|
ON CONFLICT DO NOTHING;
|
|
""",
|
|
]
|
|
|
|
|
|
def run_migrations(engine) -> None:
|
|
"""Esegue tutte le migration in transazione. Log su ciascuna."""
|
|
with engine.begin() as conn:
|
|
for i, sql in enumerate(MIGRATIONS, 1):
|
|
try:
|
|
conn.execute(text(sql))
|
|
log.info(f"migration {i}/{len(MIGRATIONS)} OK")
|
|
except Exception as e:
|
|
log.error(f"migration {i} FAILED: {e}")
|
|
raise
|