refactored code
This commit is contained in:
@@ -5,13 +5,11 @@ import java.util.List;
|
||||
import jakarta.servlet.http.HttpServletRequest;
|
||||
import net.gepafin.tendermanagement.entities.CallEntity;
|
||||
import net.gepafin.tendermanagement.enums.CallStatusEnum;
|
||||
import net.gepafin.tendermanagement.enums.UserStatusEnum;
|
||||
import net.gepafin.tendermanagement.model.request.CreateCallRequestStep1;
|
||||
import net.gepafin.tendermanagement.model.request.CreateCallRequestStep2;
|
||||
import net.gepafin.tendermanagement.model.request.UpdateCallRequestStep1;
|
||||
import net.gepafin.tendermanagement.model.response.CallDetailsResponseBean;
|
||||
import net.gepafin.tendermanagement.model.response.CallResponse;
|
||||
import net.gepafin.tendermanagement.model.response.UserResponseBean;
|
||||
|
||||
public interface CallService {
|
||||
|
||||
@@ -25,10 +23,12 @@ public interface CallService {
|
||||
|
||||
List<CallDetailsResponseBean> getAllCalls();
|
||||
|
||||
CallResponse validateCall(Long callId);
|
||||
CallResponse validateCallData(Long callId);
|
||||
|
||||
public CallEntity getCallEntityById(Long id);
|
||||
CallEntity getCallEntityById(Long id);
|
||||
|
||||
CallResponse updateCallStatus(HttpServletRequest request, Long callId, CallStatusEnum statusReq);
|
||||
|
||||
CallEntity validateCall(Long callId);
|
||||
|
||||
}
|
||||
|
||||
@@ -17,7 +17,7 @@ public interface FormFieldService {
|
||||
|
||||
public void deleteFormField(HttpServletRequest request, Long formFieldId);
|
||||
|
||||
public FormFieldEntity getFormFieldEntityById(Long id);
|
||||
public FormFieldEntity validateFormField(Long id);
|
||||
|
||||
public List<FormFieldResponseBean> getAllFormField(HttpServletRequest request);
|
||||
|
||||
|
||||
@@ -17,7 +17,7 @@ public interface FormService {
|
||||
|
||||
public void deleteForm(HttpServletRequest request, Long formId);
|
||||
|
||||
public FormEntity getFormEntityById(Long id);
|
||||
public FormEntity validateForm(Long id);
|
||||
|
||||
public List<FormResponseBean> getFormsByCallId(HttpServletRequest request,Long callId);
|
||||
}
|
||||
|
||||
@@ -17,7 +17,7 @@ public interface FormTemplateService {
|
||||
|
||||
public void deleteFormTemplate(HttpServletRequest request, Long formTemplateId);
|
||||
|
||||
public FormTemplateEntity getFormEntityById(Long id);
|
||||
public FormTemplateEntity validateFormTemplate(Long id);
|
||||
|
||||
public List<FormTemplateResponseBean> getAllFormTemplate(HttpServletRequest request);
|
||||
|
||||
|
||||
@@ -19,4 +19,6 @@ public interface LookUpDataService {
|
||||
void validateLookUpDataEntity(LookUpDataEntity lookUpDataEntity);
|
||||
|
||||
List<LookUpDataResponseBean> getLookUpDataByType(List<LookUpDataTypeEnum> type);
|
||||
|
||||
LookUpDataEntity validateLookUpData(Long lookUpDataId);
|
||||
}
|
||||
|
||||
@@ -1,9 +1,7 @@
|
||||
package net.gepafin.tendermanagement.service;
|
||||
|
||||
import net.gepafin.tendermanagement.entities.RegionEntity;
|
||||
import net.gepafin.tendermanagement.model.request.RegionReq;
|
||||
import net.gepafin.tendermanagement.model.response.RegionResponseBean;
|
||||
import net.gepafin.tendermanagement.model.request.UpdateRegionReq;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
|
||||
@@ -1,6 +1,5 @@
|
||||
package net.gepafin.tendermanagement.service;
|
||||
|
||||
import net.gepafin.tendermanagement.entities.RoleEntity;
|
||||
import net.gepafin.tendermanagement.model.request.RoleReq;
|
||||
import net.gepafin.tendermanagement.model.response.RoleResponseBean;
|
||||
|
||||
|
||||
@@ -9,7 +9,6 @@ import net.gepafin.tendermanagement.dao.RoleDao;
|
||||
import net.gepafin.tendermanagement.entities.UserEntity;
|
||||
import net.gepafin.tendermanagement.enums.UserStatusEnum;
|
||||
import net.gepafin.tendermanagement.model.request.LoginReq;
|
||||
import net.gepafin.tendermanagement.model.request.LogoutReq;
|
||||
import net.gepafin.tendermanagement.model.response.LoginResponse;
|
||||
import net.gepafin.tendermanagement.model.response.RoleResponseBean;
|
||||
import net.gepafin.tendermanagement.model.util.JWTToken;
|
||||
|
||||
@@ -64,18 +64,24 @@ public class CallServiceImpl implements CallService {
|
||||
|
||||
@Override
|
||||
@Transactional(rollbackFor = Exception.class)
|
||||
public CallResponse validateCall(Long callId) {
|
||||
return callDao.validateCall(callDao.validateCall(callId));
|
||||
public CallResponse validateCallData(Long callId) {
|
||||
return callDao.validateCallData(callDao.validateCall(callId));
|
||||
}
|
||||
|
||||
@Override
|
||||
public CallEntity getCallEntityById(Long id){
|
||||
return callDao.getCallEntityById(id);
|
||||
}
|
||||
|
||||
@Override
|
||||
@Transactional(rollbackFor = Exception.class)
|
||||
public CallResponse updateCallStatus(HttpServletRequest request, Long callId, CallStatusEnum statusReq) {
|
||||
return callDao.updateCallStatus(callId, statusReq);
|
||||
|
||||
}
|
||||
|
||||
@Override
|
||||
public CallEntity validateCall(Long callId) {
|
||||
return callDao.validateCall(callId);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -39,8 +39,8 @@ public class FormFieldServiceImpl implements FormFieldService {
|
||||
}
|
||||
|
||||
@Override
|
||||
public FormFieldEntity getFormFieldEntityById(Long id) {
|
||||
return formFieldDao.getFormFieldEntity(id);
|
||||
public FormFieldEntity validateFormField(Long id) {
|
||||
return formFieldDao.validateFormField(id);
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
@@ -39,8 +39,8 @@ public class FormServiceImpl implements FormService {
|
||||
}
|
||||
|
||||
@Override
|
||||
public FormEntity getFormEntityById(Long id) {
|
||||
return formDao.getFormEntity(id);
|
||||
public FormEntity validateForm(Long id) {
|
||||
return formDao.validateForm(id);
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
@@ -38,8 +38,8 @@ public class FormTemplateServiceImpl implements FormTemplateService {
|
||||
}
|
||||
|
||||
@Override
|
||||
public FormTemplateEntity getFormEntityById(Long id) {
|
||||
return formTemplateDao.getFormTemplateEntity(id);
|
||||
public FormTemplateEntity validateFormTemplate(Long id) {
|
||||
return formTemplateDao.validateFormTemplate(id);
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
@@ -44,4 +44,9 @@ public class LookUpDataServiceImpl implements LookUpDataService {
|
||||
public List<LookUpDataResponseBean> getLookUpDataByType( List<LookUpDataTypeEnum> type) {
|
||||
return lookUpDataDao.getLookUpDataByTypes(type);
|
||||
}
|
||||
|
||||
@Override
|
||||
public LookUpDataEntity validateLookUpData(Long lookUpDataId) {
|
||||
return lookUpDataDao.validateLookUpData(lookUpDataId);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user